Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bindAllFrom primitively #1282

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Use bindAllFrom primitively #1282

merged 3 commits into from
Jan 9, 2025

Conversation

HoshinoTented
Copy link
Contributor

Fix #1236

@HoshinoTented HoshinoTented added this to the v0.38 milestone Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.41%. Comparing base (511c97f) to head (858c1d6).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...x/src/main/java/org/aya/syntax/core/term/Term.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1282      +/-   ##
============================================
+ Coverage     83.38%   83.41%   +0.03%     
- Complexity     4219     4228       +9     
============================================
  Files           384      385       +1     
  Lines         12213    12243      +30     
  Branches       1406     1411       +5     
============================================
+ Hits          10184    10213      +29     
+ Misses         1283     1282       -1     
- Partials        746      748       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000 ice1000 enabled auto-merge January 9, 2025 21:33
@ice1000 ice1000 merged commit d68d60c into main Jan 9, 2025
4 checks passed
@ice1000 ice1000 deleted the 1236 branch January 9, 2025 21:35
@ice1000
Copy link
Member

ice1000 commented Jan 9, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instead of implementing Term::bindAt primitively, we should implement bindTele primitively
2 participants